Module:Instrument - Revision history

Magent: Fix: merge frame+parent args for Template:Guitar delegation; strip wikilinks from owner before {{m}}

2026-03-31T04:45:38Z

Fix: merge frame+parent args for Template:Guitar delegation; strip wikilinks from owner before {{m}}

← Older revision		Revision as of 04:45, 31 March 2026
Line 23:		Line 23:
	local function add(out, val)		local function add(out, val)
	if val then table.insert(out, val) end		if val then table.insert(out, val) end
			end

			local function getArg(frameArgs, parentArgs, key)
			local v = frameArgs[key]
			if v and trim(v) ~= '' then return v end
			v = parentArgs[key]
			if v and trim(v) ~= '' then return v end
			return ''
			end

			-- Strip [[ ]] wikilink markup to get plain page name
			local function stripWikilinks(s)
			-- [[Page\|Display]] -> Display; [[Page]] -> Page
			s = s:gsub('%[%[([^%]\|]+)\|([^%]]+)%]%]', '%2')
			s = s:gsub('%[%[([^%]]+)%]%]', '%1')
			return trim(s)
	end		end

	function p.infobox(frame)		function p.infobox(frame)
	local args = frame:getParent().args		-- Merge direct #invoke args with parent template args (direct wins)
	local type_ = ~~args[~~'type'~~] or~~ 'Instrument'		local fArgs = frame.args
	local nickname = ~~args[~~'nickname'~~] or ''~~		local pArgs = frame:getParent().args
	local make = ~~args[~~'make'~~] or ''~~		local type_ = getArg(fArgs, pArgs, 'type')
	local model = ~~args[~~'model'~~] or ''~~		if type_ == '' then type_ = 'Instrument' end
	local serial = ~~args[~~'serial'~~] or ''~~		local nickname = getArg(fArgs, pArgs, 'nickname')
	local year = ~~args[~~'year'~~] or ''~~		local make = getArg(fArgs, pArgs, 'make')
	local image = ~~args[~~'image'~~] or ''~~		local model = getArg(fArgs, pArgs, 'model')
	local current_owner = ~~args[~~'current_owner'~~] or ''~~		local serial = getArg(fArgs, pArgs, 'serial')
	local previous_owners = ~~args[~~'previous_owners'~~] or ''~~		local year = getArg(fArgs, pArgs, 'year')
	local body_shape = ~~args[~~'body_shape'~~] or ''~~		local image = getArg(fArgs, pArgs, 'image')
	local top_wood = ~~args[~~'top_wood'~~] or ''~~		local current_owner = getArg(fArgs, pArgs, 'current_owner')
	local back_sides_wood = ~~args[~~'back_sides_wood'~~] or ''~~		local previous_owners = getArg(fArgs, pArgs, 'previous_owners')
	local neck_wood = ~~args[~~'neck_wood'~~] or ''~~		local body_shape = getArg(fArgs, pArgs, 'body_shape')
	local fingerboard_wood = ~~args[~~'fingerboard_wood'~~] or ''~~		local top_wood = getArg(fArgs, pArgs, 'top_wood')
	local bridge_wood = ~~args[~~'bridge_wood'~~] or ''~~		local back_sides_wood = getArg(fArgs, pArgs, 'back_sides_wood')
	local scale_length = ~~args[~~'scale_length'~~] or ''~~		local neck_wood = getArg(fArgs, pArgs, 'neck_wood')
	local nut_width = ~~args[~~'nut_width'~~] or ''~~		local fingerboard_wood = getArg(fArgs, pArgs, 'fingerboard_wood')
	local strings = ~~args[~~'strings'~~] or ''~~		local bridge_wood = getArg(fArgs, pArgs, 'bridge_wood')
	local electronics = ~~args[~~'electronics'~~] or ''~~		local scale_length = getArg(fArgs, pArgs, 'scale_length')
			local nut_width = getArg(fArgs, pArgs, 'nut_width')
			local strings = getArg(fArgs, pArgs, 'strings')
			local electronics = getArg(fArgs, pArgs, 'electronics')

	-- SMW properties via #set parser function		-- SMW properties via #set parser function
Line 110:		Line 129:

	if trim(current_owner) ~= '' then		if trim(current_owner) ~= '' then
	local ownerDisplay = trim(frame:expandTemplate{ title = 'm', args = { ~~current_owner~~ } })		local ownerName = stripWikilinks(current_owner)
			local ownerDisplay = trim(frame:expandTemplate{ title = 'm', args = { ownerName } })
	add(out, row('Owner', ownerDisplay))		add(out, row('Owner', ownerDisplay))
	end		end

Magent: Fix alignment: trim whitespace, remove trailing newlines from row output

2026-03-31T04:24:09Z

Fix alignment: trim whitespace, remove trailing newlines from row output

← Older revision		Revision as of 04:24, 31 March 2026
Line 1:		Line 1:
	local p = {}		local p = {}

			local function trim(s)
			return s:match('^%s(.-)%s$')
			end

	local function row(label, value)		local function row(label, value)
	if not value or value == '' then return '' end		if not value or trim(value) == '' then return nil end
	return ~~string.format(~~		return '\|-\n! style="text-align: right; padding: 3px;" \| ' .. label .. '\n\| style="padding: 3px;" \| ' .. trim(value)
	'\|-\n! style="text-align: right; padding: 3px;" \| %s\n\| style="padding: 3px;" \| ~~%s\n~~',
	~~label,~~ value
	)
	end		end

	local function sectionHeader(label)		local function sectionHeader(label)
	return ~~string.format(~~		return '\|-\n! colspan="2" style="background: #ddd; padding: 3px;" \| ' .. label
	'\|-\n! colspan="2" style="background: #ddd; padding: 3px;" \| ~~%s\n~~',
	label
	)
	end		end

	local function any(...)		local function any(...)
	for _, v in ipairs({...}) do		for _, v in ipairs({...}) do
	if v and v ~= '' then return true end		if v and trim(v) ~= '' then return true end
	end		end
	return false		return false
			end

			local function add(out, val)
			if val then table.insert(out, val) end
	end		end

Line 98:		Line 100:
	table.insert(out, '! colspan="2" style="background: #ccc; font-size: 1.1em; padding: 5px;" \| ' .. header)		table.insert(out, '! colspan="2" style="background: #ccc; font-size: 1.1em; padding: 5px;" \| ' .. header)

	if image ~= '' then		if trim(image) ~= '' then
	table.insert(out, '\|-')		table.insert(out, '\|-')
	table.insert(out, '\| colspan="2" style="text-align: center; padding: 10px;" \| [[File:' .. image .. '\|280px]]')		table.insert(out, '\| colspan="2" style="text-align: center; padding: 10px;" \| [[File:' .. trim(image) .. '\|280px]]')
	end		end

	~~table.insert~~(out, row('Type', type_))		add(out, row('Type', type_))
	~~table.insert~~(out, row('Serial', serial))		add(out, row('Serial', serial))
	~~table.insert~~(out, row('Year', year))		add(out, row('Year', year))

	if current_owner ~= '' then		if trim(current_owner) ~= '' then
	local ownerDisplay = frame:expandTemplate{ title = 'm', args = { current_owner } }		local ownerDisplay = trim(frame:expandTemplate{ title = 'm', args = { current_owner } })
	~~table.insert~~(out, row('Owner', ownerDisplay))		add(out, row('Owner', ownerDisplay))
	end		end
	~~table.insert~~(out, row('Previous', previous_owners))		add(out, row('Previous', previous_owners))

	if any(body_shape, top_wood, back_sides_wood, neck_wood, fingerboard_wood, bridge_wood) then		if any(body_shape, top_wood, back_sides_wood, neck_wood, fingerboard_wood, bridge_wood) then
	table.insert(out, sectionHeader('Construction'))		table.insert(out, sectionHeader('Construction'))
	~~table.insert~~(out, row('Body', body_shape))		add(out, row('Body', body_shape))
	~~table.insert~~(out, row('Top', top_wood))		add(out, row('Top', top_wood))
	~~table.insert~~(out, row('Back/Sides', back_sides_wood))		add(out, row('Back/Sides', back_sides_wood))
	~~table.insert~~(out, row('Neck', neck_wood))		add(out, row('Neck', neck_wood))
	~~table.insert~~(out, row('Fingerboard', fingerboard_wood))		add(out, row('Fingerboard', fingerboard_wood))
	~~table.insert~~(out, row('Bridge', bridge_wood))		add(out, row('Bridge', bridge_wood))
	end		end

	if any(scale_length, nut_width, strings) then		if any(scale_length, nut_width, strings) then
	table.insert(out, sectionHeader('Specifications'))		table.insert(out, sectionHeader('Specifications'))
	~~table.insert~~(out, row('Scale', scale_length))		add(out, row('Scale', scale_length))
	~~table.insert~~(out, row('Nut Width', nut_width))		add(out, row('Nut Width', nut_width))
	~~table.insert~~(out, row('Strings', strings))		add(out, row('Strings', strings))
	end		end

	if electronics ~= '' then		if trim(electronics) ~= '' then
	table.insert(out, sectionHeader('Electronics'))		table.insert(out, sectionHeader('Electronics'))
	table.insert(out, '\|-')		table.insert(out, '\|-')
	table.insert(out, '\| colspan="2" style="padding: 3px;" \| ' .. electronics)		table.insert(out, '\| colspan="2" style="padding: 3px;" \| ' .. trim(electronics))
	end		end

Magent: Fix: use frame:callParserFunction for #set instead of mw.smw (Semantic Scribunto not installed)

2026-03-31T04:00:32Z

Fix: use frame:callParserFunction for #set instead of mw.smw (Semantic Scribunto not installed)

← Older revision		Revision as of 04:00, 31 March 2026
Line 45:		Line 45:
	local electronics = args['electronics'] or ''		local electronics = args['electronics'] or ''

	-- SMW properties		-- SMW properties via #set parser function
	local ~~smw = mw.smw~~		local setArgs = {}
	~~if smw then~~		local propMap = {
	~~local setProps~~ = {}		['Instrument type'] = type_,
	local propMap = {		['Nickname'] = nickname,
	['Instrument type'] = type_,		['Make'] = make,
	['Nickname'] = nickname,		['Model'] = model,
	['Make'] = make,		['Serial'] = serial,
	['Model'] = model,		['Year built'] = year,
	['Serial'] = serial,		['Current owner'] = current_owner,
	['Year built'] = year,		['Body shape'] = body_shape,
	['Current owner'] = current_owner,		['Top wood'] = top_wood,
	['Body shape'] = body_shape,		['Back and sides wood'] = back_sides_wood,
	['Top wood'] = top_wood,		['Neck wood'] = neck_wood,
	['Back and sides wood'] = back_sides_wood,		['Fingerboard wood'] = fingerboard_wood,
	['Neck wood'] = neck_wood,		['Bridge wood'] = bridge_wood,
	['Fingerboard wood'] = fingerboard_wood,		['Scale length'] = scale_length,
	['Bridge wood'] = bridge_wood,		['Nut width'] = nut_width,
	['Scale length'] = scale_length,		['Number of strings'] = strings,
	['Nut width'] = nut_width,		['Electronics'] = electronics,
	['Number of strings'] = strings,		}
	['Electronics'] = electronics,		for k, v in pairs(propMap) do
	}		if v ~= '' then
	for k, v in pairs(propMap) do		table.insert(setArgs, k .. '=' .. v)
	if v ~= '' then ~~setProps[~~k] = v ~~end~~
	end		end
	~~smw.~~set~~(setProps~~)		end
			if #setArgs > 0 then
			frame:callParserFunction('#set', setArgs)
	end		end

Magent: Create Lua instrument infobox module

2026-03-31T03:58:35Z

Create Lua instrument infobox module

New page

local p = {}

local function row(label, value)
if not value or value == '' then return '' end
return string.format(
'|-\n! style="text-align: right; padding: 3px;" | %s\n| style="padding: 3px;" | %s\n',
label, value
)
end

local function sectionHeader(label)
return string.format(
'|-\n! colspan="2" style="background: #ddd; padding: 3px;" | %s\n',
label
)
end

local function any(...)
for _, v in ipairs({...}) do
if v and v ~= '' then return true end
end
return false
end

function p.infobox(frame)
local args = frame:getParent().args
local type_ = args['type'] or 'Instrument'
local nickname = args['nickname'] or ''
local make = args['make'] or ''
local model = args['model'] or ''
local serial = args['serial'] or ''
local year = args['year'] or ''
local image = args['image'] or ''
local current_owner = args['current_owner'] or ''
local previous_owners = args['previous_owners'] or ''
local body_shape = args['body_shape'] or ''
local top_wood = args['top_wood'] or ''
local back_sides_wood = args['back_sides_wood'] or ''
local neck_wood = args['neck_wood'] or ''
local fingerboard_wood = args['fingerboard_wood'] or ''
local bridge_wood = args['bridge_wood'] or ''
local scale_length = args['scale_length'] or ''
local nut_width = args['nut_width'] or ''
local strings = args['strings'] or ''
local electronics = args['electronics'] or ''

-- SMW properties
local smw = mw.smw
if smw then
local setProps = {}
local propMap = {
['Instrument type'] = type_,
['Nickname'] = nickname,
['Make'] = make,
['Model'] = model,
['Serial'] = serial,
['Year built'] = year,
['Current owner'] = current_owner,
['Body shape'] = body_shape,
['Top wood'] = top_wood,
['Back and sides wood'] = back_sides_wood,
['Neck wood'] = neck_wood,
['Fingerboard wood'] = fingerboard_wood,
['Bridge wood'] = bridge_wood,
['Scale length'] = scale_length,
['Nut width'] = nut_width,
['Number of strings'] = strings,
['Electronics'] = electronics,
}
for k, v in pairs(propMap) do
if v ~= '' then setProps[k] = v end
end
smw.set(setProps)
end

-- Header
local header
if make ~= '' then
header = make .. ' ' .. model
if serial ~= '' then
if tonumber(serial) then
header = header .. ' #' .. serial
else
header = header .. ' ' .. serial
end
end
elseif nickname ~= '' then
header = "''" .. nickname .. "''"
else
header = type_
end

-- Build table
local out = {}
table.insert(out, '{| class="infobox" style="width: 300px; border: 1px solid #aaa; background: #f9f9f9; padding: 10px; margin: 0 0 1em 1em; float: right;"')
table.insert(out, '|-')
table.insert(out, '! colspan="2" style="background: #ccc; font-size: 1.1em; padding: 5px;" | ' .. header)

if image ~= '' then
table.insert(out, '|-')
table.insert(out, '| colspan="2" style="text-align: center; padding: 10px;" | [[File:' .. image .. '|280px]]')
end

table.insert(out, row('Type', type_))
table.insert(out, row('Serial', serial))
table.insert(out, row('Year', year))

if current_owner ~= '' then
local ownerDisplay = frame:expandTemplate{ title = 'm', args = { current_owner } }
table.insert(out, row('Owner', ownerDisplay))
end
table.insert(out, row('Previous', previous_owners))

if any(body_shape, top_wood, back_sides_wood, neck_wood, fingerboard_wood, bridge_wood) then
table.insert(out, sectionHeader('Construction'))
table.insert(out, row('Body', body_shape))
table.insert(out, row('Top', top_wood))
table.insert(out, row('Back/Sides', back_sides_wood))
table.insert(out, row('Neck', neck_wood))
table.insert(out, row('Fingerboard', fingerboard_wood))
table.insert(out, row('Bridge', bridge_wood))
end

if any(scale_length, nut_width, strings) then
table.insert(out, sectionHeader('Specifications'))
table.insert(out, row('Scale', scale_length))
table.insert(out, row('Nut Width', nut_width))
table.insert(out, row('Strings', strings))
end

if electronics ~= '' then
table.insert(out, sectionHeader('Electronics'))
table.insert(out, '|-')
table.insert(out, '| colspan="2" style="padding: 3px;" | ' .. electronics)
end

local detailsForm = ({
Guitar = 'GuitarDetails',
Banjo = 'BanjoDetails',
Mandolin = 'MandolinDetails',
})[type_] or 'InstrumentDetails'

local pageName = mw.title.getCurrentTitle().fullText
table.insert(out, '|-')
table.insert(out, '| colspan="2" style="text-align: center; padding: 8px 3px 3px;" | [[Special:FormEdit/' .. detailsForm .. '/' .. pageName .. '|Add details & photos]]')
table.insert(out, '|}')
table.insert(out, '[[Category:Instruments]][[Category:' .. type_ .. 's]]')

return table.concat(out, '\n')
end

return p